More fixes related to the caldav syncing (#209)

alextselegidis · May 12, 2024 · ab8257f · ab8257f
1 parent 2aea423
commit ab8257f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/application/libraries/Caldav_sync.php b/application/libraries/Caldav_sync.php
@@ -70,7 +70,8 @@ public function save_appointment(array $appointment, array $service, array $prov
 
             $caldav_calendar = $provider['settings']['caldav_calendar'];
 
-            $caldav_event_id = $this->CI->ics_file->generate_uid($appointment['id']) . '.ics';
+            $caldav_event_id =
+                $appointment['id_caldav_calendar'] ?: $this->CI->ics_file->generate_uid($appointment['id']);
 
             $uri = $this->get_caldav_event_uri($caldav_calendar, $caldav_event_id);
 
@@ -107,7 +108,8 @@ public function save_unavailability(array $unavailability, array $provider): ?st
 
             $caldav_calendar = $provider['settings']['caldav_calendar'];
 
-            $caldav_event_id = $this->CI->ics_file->generate_uid($unavailability['id']) . '.ics';
+            $caldav_event_id =
+                $unavailability['id_caldav_calendar'] ?: $this->CI->ics_file->generate_uid($unavailability['id']);
 
             $uri = $this->get_caldav_event_uri($caldav_calendar, $caldav_event_id);
 
@@ -420,7 +422,7 @@ private function get_http_client_by_provider_id(int $provider_id): Client
      */
     private function get_caldav_event_uri(string $caldav_calendar, ?string $caldav_event_id = null): string
     {
-        return trim($caldav_calendar, '/') . ($caldav_event_id ? '/' . $caldav_event_id : '');
+        return trim($caldav_calendar, '/') . ($caldav_event_id ? '/' . $caldav_event_id . '.ics' : '');
     }
 
     /**

diff --git a/application/libraries/Ics_file.php b/application/libraries/Ics_file.php
@@ -78,7 +78,7 @@ public function get_stream(array $appointment, array $service, array $provider,
             ->setEnd($appointment_end)
             ->setStatus('CONFIRMED')
             ->setSummary($service['name'])
-            ->setUid($this->generate_uid($appointment['id']));
+            ->setUid($appointment['id_caldav_calendar'] ?: $this->generate_uid($appointment['id']));
 
         if (!empty($service['location'])) {
             $location = new Location();
@@ -198,7 +198,7 @@ public function get_unavailability_stream(array $unavailability, array $provider
             ->setEnd($unavailability_end)
             ->setStatus('CONFIRMED')
             ->setSummary('Unavailability')
-            ->setUid($this->generate_uid($unavailability['id']));
+            ->setUid($unavailability['id_caldav_calendar'] ?: $this->generate_uid($unavailability['id']));
 
         $event->setDescription(str_replace("\n", "\\n", (string) $unavailability['notes']));
 

diff --git a/application/libraries/Synchronization.php b/application/libraries/Synchronization.php
@@ -36,6 +36,7 @@ public function __construct()
         $this->CI->load->model('appointments_model');
 
         $this->CI->load->library('google_sync');
+        $this->CI->load->library('caldav_sync');
     }
 
     /**