Unset the "password" and "salt" parameter when getting a user or a pr…

…ovider
alextselegidis · Oct 3, 2022 · 6d413ff · 6d413ff
1 parent a01acc5
commit 6d413ff
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/application/models/Providers_model.php b/application/models/Providers_model.php
@@ -327,7 +327,11 @@ public function find(int $provider_id, bool $with_trashed = FALSE): array
 
         $provider['settings'] = $this->db->get_where('user_settings', ['id_users' => $provider_id])->row_array();
 
-        unset($provider['settings']['id_users']);
+        unset(
+            $provider['settings']['id_users'],
+            $provider['settings']['password'],
+            $provider['settings']['salt'],
+        );
 
         $service_provider_connections = $this->db->get_where('services_providers', ['id_users' => $provider_id])->result_array();
 

diff --git a/application/models/Users_model.php b/application/models/Users_model.php
@@ -219,7 +219,11 @@ public function find(int $user_id, bool $with_trashed = FALSE): array
 
         $user['settings'] = $this->db->get_where('user_settings', ['id_users' => $user_id])->row_array();
 
-        unset($user['settings']['id_users']);
+        unset(
+            $user['settings']['id_users'],
+            $user['settings']['password'],
+            $user['settings']['salt'],
+        );
 
         return $user;
     }
@@ -430,6 +434,14 @@ public function search(string $keyword, int $limit = NULL, int $offset = NULL, s
         foreach ($users as &$user)
         {
             $this->cast($user);
+
+            $user['settings'] = $this->db->get_where('user_settings', ['id_users' => $user['id']])->row_array();
+
+            unset(
+                $user['settings']['id_users'],
+                $user['settings']['password'],
+                $user['settings']['salt']
+            );
         }
 
         return $users;