Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple entries where second is intersecting #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abhishek-031
Copy link

Proposing a fix for issue #112
Earlier the observer callback was only checking if the first entry is intersecting with the viewport but in some cases there can be multiple entries in the callback where the code only checks for the first one and if the first one is false and any other is true the code breaks.
Trying to check if any entry is intersecting is a viable solution to fix this.
Attaching a screen shot of the console reproducing the issue.
Screenshot 2023-04-11 at 4 55 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant