Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component-interface): egress and ingress interface for ac skill … #733

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

AbhiPwr
Copy link
Collaborator

@AbhiPwr AbhiPwr commented Mar 30, 2023

…components

An interface defined for each Component to follow for ingressing or egressing out of it.

Description

We have various AC skill components (https://github.com/alexa/skill-components). We want to abstract certain details from a skill developer and make it easy to enter (ingress) or egress (exit) from a skill component. This way a developer can then simple use those functions of a skill component in an easy way.

Motivation and Context

We want to abstract certain details from a skill developer and make it easy to enter (ingress) or egress (exit) from a skill component. This way a developer can then simple use those functions of a skill component in an easy way.

Testing

Installed a catalog-explorer component in the skill. Ingressed into the same using launch method. Once, catalog explorer flow was completed, also ensured that we egress out of the component.

Self owned Lambda hosted skill + ASKX for ACDL

These are new changes and hence dont affect the existing code

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs(Add new document content)
  • Translate Docs(Translate document content)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My commit message follows Conventional Commit Guideline

License

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abhjroy abhjroy merged commit e9b26ae into alexa:2.0.x Apr 3, 2023
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants