Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take 2 Global Settings and User Settings #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Take 2 Global Settings and User Settings #248

wants to merge 1 commit into from

Conversation

nhojpatrick
Copy link
Contributor

Another approach to #244

Adding gitflow.maven.settings.global and gitflow.maven.settings.user as plugin properties.

If -gs is already in the argLine it is skipped, same handling for -s.

@nhojpatrick nhojpatrick mentioned this pull request Aug 18, 2020
Open
@nhojpatrick nhojpatrick force-pushed the feature/settings-files_not-argLine-magic branch from 01f5b38 to 6dc1059 Compare September 5, 2020 23:38
@nhojpatrick nhojpatrick force-pushed the feature/settings-files_not-argLine-magic branch from 6dc1059 to ad2458a Compare January 15, 2021 10:35
@nhojpatrick
Copy link
Contributor Author

@aleksandr-m any thoughts about this PR, like the maven wrapper detection PR. It defines the variables the parent process automatically detected for -gs or -s, but if they are specified they are skipped. And if they are defined as a property those are used instead.

@nhojpatrick nhojpatrick force-pushed the feature/settings-files_not-argLine-magic branch from ad2458a to 03d5e10 Compare January 17, 2021 20:20
@nhojpatrick nhojpatrick force-pushed the feature/settings-files_not-argLine-magic branch from 03d5e10 to 53f922c Compare January 29, 2021 10:09
@nhojpatrick nhojpatrick force-pushed the feature/settings-files_not-argLine-magic branch from 53f922c to 26e1238 Compare February 15, 2021 09:47
@nhojpatrick
Copy link
Contributor Author

@aleksandr-m want to add you as a reviewer and request a review but don't have permissions to do that.

@nhojpatrick nhojpatrick force-pushed the feature/settings-files_not-argLine-magic branch from 26e1238 to 6669547 Compare September 9, 2021 07:26
@nhojpatrick
Copy link
Contributor Author

@aleksandr-m can this also be review and hopefully merged please. This and the other would result vm config and extra pom config.

@nhojpatrick nhojpatrick force-pushed the feature/settings-files_not-argLine-magic branch from 6669547 to 73d1779 Compare September 18, 2021 12:07
@stefanseifert
Copy link
Contributor

+1, i hit the same problem when developing the ITs for #323

@stefanseifert stefanseifert mentioned this pull request Jan 4, 2022
Merged
stefanseifert
stefanseifert reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to also add an integration test with custom maven settings.
i can help with this - or get inspiration from my PR #323 where i already had a use case to pass custom maven settings within an IT

src/main/java/com/amashchenko/maven/plugin/gitflow/AbstractGitFlowMojo.java Show resolved Hide resolved
src/main/java/com/amashchenko/maven/plugin/gitflow/AbstractGitFlowMojo.java Show resolved Hide resolved
@nhojpatrick nhojpatrick force-pushed the feature/settings-files_not-argLine-magic branch 2 times, most recently from aff19f6 to c0648de Compare March 14, 2022 23:49
@nhojpatrick nhojpatrick force-pushed the feature/settings-files_not-argLine-magic branch from c0648de to e8d1796 Compare October 13, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanseifert stefanseifert stefanseifert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhojpatrick @stefanseifert