Add multiple hdf5 versions for static building #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulimoen
force-pushed
the
feature/static-multi-versions
branch
3 times, most recently
from
ca82a36
to
78e1908
Compare
mulimoen
changed the title
mulimoen
force-pushed
the
feature/static-multi-versions
branch
2 times, most recently
from
b884c57
to
4ac7433
Compare
|
@aldanor This PR also fixes CI |
mulimoen
force-pushed
the
feature/static-multi-versions
branch
from
9eaa6eb
to
571ca1b
Compare
mulimoen
force-pushed
the
feature/static-multi-versions
branch
2 times, most recently
from
8a210c8
to
daef5cc
Compare
This was referenced May 3, 2022
Merged
|
@aldanor It would be great if you could have a look at this! |
mulimoen
force-pushed
the
feature/static-multi-versions
branch
from
43969c5
to
cb42392
Compare
|
I replaced hdf5 1.13 (which was a beta lineage) with 1.14.0. This requires #227 |
mulimoen
force-pushed
the
feature/static-multi-versions
branch
from
52777e0
to
f031764
Compare
|
Do we want to go ahead with this? If so, 1.13->1.14 and will need a rebase? |
|
Would be easier to bump the bundled |
|
Probably, yea... Now that 1.14 is stable, is out on most platforms and package managers and will be a default version of choice for a long while anyway, I guess, we can just bundle it as a default as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature toggle to allow more recent versions of hdf5, 1.12.1 or 1.13.1. Crate size is 9.2M, should still be small enough to be uploaded to crates.io.