Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed jquery selector issue, added more logging #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjsobrep
Copy link
Contributor

This should fix #7 #9 #8 It would be good to have the people who raised the issue check the fix.

@Tiradoc
Copy link

Tiradoc commented Nov 8, 2019

I have tried these update versions in qualtrics, and the images are not showing up. Any ideas?

@mjsobrep
Copy link
Contributor Author

mjsobrep commented Nov 8, 2019

@Tiradoc Can you give me some more details? It is working for me, but maybe I did something differently than you. How did you set up? What does it look like (screenshot). What is printed in the debug console (F12)?

@Tiradoc
Copy link

Tiradoc commented Nov 8, 2019 via email

@mjsobrep
Copy link
Contributor Author

mjsobrep commented Nov 9, 2019

@Tiradoc that looks like the old code. The offending line is the var labels = $(qid).descendants().grep(new Selector('.statement-container'));
It should be:

	var labels =  jQuery.grep($(qid).descendants(),function(n, i) {
    	return (n.className == 'statement-container');
	});

Maybe you copied from the wrong place? Take a look at the files here: https://github.com/mjsobrep/AffectiveSlider/tree/selector-fix/qualtrics

@Tiradoc
Copy link

Tiradoc commented Nov 9, 2019 via email

@mjsobrep
Copy link
Contributor Author

@albertobeta any chance of getting this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing images to Qualtrics?
2 participants