Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

begin clearing errors and warning #13

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

u-an-i
Copy link

@u-an-i u-an-i commented Jun 6, 2021

80 % type-based:
added,
Qt:: added,
Qyyy::ENUM changed,
QVector overlaods deleted (is alias of QList),
QzzzLiteral are now simply QzzzString,
QFileInfo constructor around paths,
comparison with letters: 'A' (not "A"),
some new methods ("secsSinceEpoch" instead of "time_t", "setEncoding" instead of "setCodec",
...
some explicit casts (5%)
some msvc #pragmas (5%)
logic adjusment File Dialog (3%),
logic correction SQL (7%) (prepared statement placeholders have no API to get them!)

80 %  type-based:
 <Qxxx> added,
 Qt:: added,
 Qyyy::ENUM changed,
 QVector overlaods deleted (is alias of QList),
 QzzzLiteral are now simply QzzzString,
 QFileInfo constructor around paths,
 comparison with letters: 'A' (not "A"),
 some new methods ("secsSinceEpoch" instead of "time_t", "setEncoding" instead of "setCodec",
 ...
some explicit casts (5%)
some msvc #pragmas (5%)
logic adjusment File Dialog (3%),
logic correction SQL (7%) (prepared statement placeholders have no API to get them!)
@u-an-i
Copy link
Author

u-an-i commented Jun 6, 2021

For reference:

image
image

image
image
image
image
image
image
image
image

@albar965
Copy link
Owner

Not sure if I want to go the Qt 6 path. Looks like a lot of effort and I expect plenty of side effects. I even don't want to know what the dock window management is doing now. 🙁

@u-an-i
Copy link
Author

u-an-i commented Jun 10, 2021

i leave this PR here in draft state not continuing the upgrade for now.

@albar965
Copy link
Owner

Let's keep this in mind for a future version. Maybe after 2.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants