Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web seed request order #639

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Web seed request order #639

wants to merge 3 commits into from

Conversation

borigas
Copy link
Contributor

@borigas borigas commented Mar 5, 2023

Closes #638

  • Adds test for webseed with padding between files
  • Takes padding into account when building http requests from blocks
  • Fixes issue where List<BlockInfo> bundle is non-sequential and non-adjacent, leading to requests with negative byte ranges, negative endIndex, and extra requests for ranges that are already downloaded
    • I couldn't isolate this into a reproducible test that I could share, but by pre-populating some of the destination files, this would happen more often than not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebSeed: Pieces get out of order and create an http request with a negative end
1 participant
@borigas