Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing from Google form sign-up to new E&S MS forms #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changing from Google form sign-up to new E&S MS forms #113

wants to merge 1 commit into from
+8 −12

Conversation

kallewesterling
Copy link
Collaborator

No description provided.

@kallewesterling
Copy link
Collaborator Author

@cassgvp Just wanted to make sure you see this!

cassgvp
cassgvp approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@cassgvp cassgvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!! 🚀

@cassgvp cassgvp closed this May 17, 2024
@cassgvp cassgvp reopened this May 17, 2024
@kallewesterling
Copy link
Collaborator Author

@davidwilby Do you have any idea why the tests fail here? We haven't edited anything but the documentation :/

@tom-andersson
Copy link
Collaborator

The failing tests are unrelated to this PR, so feel free to merge. I have opened an issue for the failing tests: #115. Just make sure to handle any remaining requests on the Google form before the switch is made please!

Hint: @cassgvp ‘rebase and merge’ rather than closing the PR! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassgvp cassgvp cassgvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kallewesterling @tom-andersson @cassgvp