New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add from_file_descriptors()
to tty::unix
#7940
Add from_file_descriptors()
to tty::unix
#7940
Conversation
from_file_descriptors
to tty::unix
from_file_descriptors()
to tty::unix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for this change? A use case for a consumer application?
I'm working on Flatpak support for Zed, which uses I figured the least intrusive way of doing this was just introducing a new function which lets you pass your own file descriptors. |
8f214b5
to
a367144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems simple enough and the stuff you have to do outside is also trivial (openpty
).
So this solution makes more sense than basically exposing a function that is the same as openpty
just with some spawn
call attached.
a367144
to
4a2fd6b
Compare
4a2fd6b
to
9874565
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
Just letting @chrisduerr make the final review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another tiny nitpick. Doubt I can find anything else.
Co-authored-by: Christian Duerr <contact@christianduerr.com>
@someone13574 Do you need this released? |
Yes, that would be awesome. |
No promises on the ETA, but I'll try and get a release out this week. |
Adds a function to create a
Pty
handle from file descriptors opened outside of Alacritty. This does not break backward compatibility.