-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for S3 as external data source #981
base: main
Are you sure you want to change the base?
Conversation
053063a
to
271ebfe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
==========================================
- Coverage 84.84% 84.68% -0.16%
==========================================
Files 186 189 +3
Lines 7238 7322 +84
Branches 38 38
==========================================
+ Hits 6141 6201 +60
- Misses 1095 1119 +24
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8ca71e3
to
c633117
Compare
ddef829
to
9f1820f
Compare
9f1820f
to
b218267
Compare
Note I didn't have a look as I understand this is still work in progress. Tell me when you need some comments. |
Hi, |
Sorry for taking some time. I am fine with the feature, however I have a few remarks on the implementation.
|
This PR adds support for S3:
With S3 as alternative to local storage, Kubernetes-Like deployment (see e.g. #891) are made easier, as the components itself don't need persistent storage.
Still open: