Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple some config to .env + suggestion on security #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pietrobondioli
Copy link

Description:

This pull request introduces a .env.sample file for secure environment variable management and updates the Docker Compose files to use these variables. Additionally, the README is revised to guide users on setting up their .env file.

Key Changes:

  • Added .env.sample with variables like HOME, PIHOLE_WEBPASSWORD, and KAIZOKU_DB_PASSWORD.
  • Updated Docker Compose files to reference variables from .env.
  • Updated README with instructions for using .env.sample.

Security Note:

  • Rewrote history to remove hardcoded WEBPASSWORD. This change is on the main-safe-history
  • Repository owner should consider force-pushing this branch to the main to remove the exposed credentials from history.

( I tried to open a pull request with the rewritten history but looks like github doesn't allow this kind of operation :/ )

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant