Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add show links to episode page #158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fracai
Copy link
Contributor

@fracai fracai commented Sep 23, 2021

Adds links to the podcast page for each episode result on the filterable episodes page.

@muse-sisay
Copy link

@fracai Could you add show links in the player page? Please refer to my issue #99

@fracai
Copy link
Contributor Author

fracai commented Oct 7, 2021

@muse-sisay I have a solution that I'll get together later today

@muse-sisay
Copy link

Sorry for taking a while to reply.
It works as requested but the when I click the show name it stops what I am currently listening. Any solution to have it keep playing while I browse? ( Like those music streaming services, you can listen to your podcast while browsing).

I wish the links where not underlined.
Thank you.

@fracai
Copy link
Contributor Author

fracai commented Oct 13, 2021

Not underlining would be easy enough. I personally don’t mind as it calls out the link versus just being a label, but I don’t have strong feelings there.

The playback would be much harder I think. The easiest solution would be to open the link in a new tab, manually or changing the link behavior. As is, the player is on that page, so navigating to a different page and still playing would require keeping the player in a frame that doesn’t change and loading the new page in a different frame on the same page. I’m sure there’s a way to do this in a nice way, but it’s a bigger change than makes sense for this PR.

@muse-sisay
Copy link

You're completely right, now I think about it, Podgrab was designed to be an archiving tool and not a player. Refer #146 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants