Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only modify the prompt if the shell is in vterm #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fapdash
Copy link

@fapdash fapdash commented Sep 7, 2020

Without this check the config messed up the prompt in the GNOME terminal.

Without this check the config messed up the prompt in the GNOME terminal.
@Sbozzolo
Copy link
Collaborator

Sbozzolo commented Sep 7, 2020

We have to find a way to propagate INSIDE_EMACS to ssh sessions, otherwise this will not work.

@fapdash
Copy link
Author

fapdash commented Sep 7, 2020

Can you please explain the problem a bit more? Once we're connected with a remote server via ssh then this terminal session runs with the config of the remote server anways, no?

@Sbozzolo
Copy link
Collaborator

Sbozzolo commented Sep 8, 2020

Yes, if I have these configs on my remote servers, they will not work if INSIDE_EMACS is not defined. So, if we want to modify the prompt (and add the other functions) only in vterm. We have to somehow make sure that INSIDE_EMACS is set to something also when we are ssh-ed somewhere.

@fapdash
Copy link
Author

fapdash commented Sep 11, 2020

Would this do the trick? https://superuser.com/a/702751

@Sbozzolo
Copy link
Collaborator

Sbozzolo commented Sep 11, 2020

Unfortunately, that solution relies on server-side configurations that often cannot be controlled by the user. A workaround would be to pass the information inside an LC_* variable, but this is not very satisfying. Some servers block these too. The only one that always should go through is TERM, but changing it may lead to other problems.

@jixiuf jixiuf force-pushed the master branch 2 times, most recently from 9a6dbeb to a2f2286 Compare April 14, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants