Proposal issue 9868 #10148
Closed
Proposal issue 9868 #10148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uct to use param-based form-type
|
As we use Akeneo EE, I opened a ticket on EE Helpdesk in addition to this PR. I got the response, that the direkt use of classes-names instead of parameters in the dependency config was a technical decision. Thats why this code change is not valid and I will close the PR. |
ghost
closed this
|
Alas, all the DI is not migrated to "hard coded classes" but we will indeed stop using classname as parameters. More info can be found on Symfony Best practices: https://symfony.com/doc/3.4/best_practices/business-logic.html#service-no-class-parameter |
|
I made a PR to fix the documentation accordingly. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes services definition of pim_enrich.controller.category_tree.product to use param-based form-type
Description (for Contributor and Core Developer)
#9868