Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added URI(s) section under STEP 7 #195

Merged
merged 5 commits into from
May 23, 2024

Conversation

hiroyukikumazawa
Copy link
Contributor

No description provided.

@hiroyukikumazawa
Copy link
Contributor Author

for #124

Copy link
Contributor

@andy108369 andy108369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hiroyukikumazawa !

It wouldn't hurt leaving the Forwarded ports as-is though. Along with the newly added URI(s) section.
That way one can quickly refer to that image when one needs to point out where one needs to be looking for to locate the forwarded (mapped) ports.

@hiroyukikumazawa
Copy link
Contributor Author

Hey @hiroyukikumazawa !

It wouldn't hurt leaving the Forwarded ports as-is though. Along with the newly added URI(s) section. That way one can quickly refer to that image when one needs to point out where one needs to be looking for to locate the forwarded (mapped) ports.

Ok

@hiroyukikumazawa
Copy link
Contributor Author

@andy108369 please review again.
Thank you.

@HoomanHQ
Copy link
Collaborator

@hiroyukikumazawa : It seems that you added the image as requested, but you also need to mention the image path in the Markdown file of the docs.

@hiroyukikumazawa
Copy link
Contributor Author

hiroyukikumazawa commented May 14, 2024

@hiroyukikumazawa : It seems that you added the image as requested, but you also need to mention the image path in the Markdown file of the docs.

I have replaced the image.
Which markdown file have you mentioned? @HoomanHQ

@HoomanHQ
Copy link
Collaborator

@hiroyukikumazawa as mentioned by @andy108369 : could you plzz keep the previous image as in and implement new image as additional image instead of replacement?

@hiroyukikumazawa
Copy link
Contributor Author

@hiroyukikumazawa as mentioned by @andy108369 : could you plzz keep the previous image as in and implement new image as additional image instead of replacement?

ok, no problem

@hiroyukikumazawa
Copy link
Contributor Author

updated @HoomanHQ, @andy108369 .
please check again

@hiroyukikumazawa
Copy link
Contributor Author

@HoomanHQ
Copy link
Collaborator

@andy108369: Could you please give a final review and approval? This seems good to go.

@HoomanHQ HoomanHQ merged commit a652c46 into akash-network:main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants