Skip to content

Commit

Permalink
fix(sdl): add missing ram token for gpu attributes (#1926)
Browse files Browse the repository at this point in the history
Signed-off-by: Artur Troian <troian.ap@gmail.com>
  • Loading branch information
troian committed Feb 27, 2024
1 parent 23da352 commit 6ad32ce
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion sdl/gpu.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type v2GPUNvidia struct {
func (sdl *v2GPUNvidia) String() string {
key := sdl.Model
if sdl.RAM != nil {
key += "/" + sdl.RAM.StringWithSuffix("Gi")
key += "/ram/" + sdl.RAM.StringWithSuffix("Gi")
}

return key
Expand Down
8 changes: 4 additions & 4 deletions sdl/gpu_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ attributes:
require.NoError(t, err)
require.Equal(t, gpuQuantity(1), p.Units)
require.Equal(t, 1, len(p.Attributes))
require.Equal(t, "vendor/nvidia/model/a100/80Gi", p.Attributes[0].Key)
require.Equal(t, "vendor/nvidia/model/a100/ram/80Gi", p.Attributes[0].Key)
require.Equal(t, "true", p.Attributes[0].Value)
}

Expand Down Expand Up @@ -105,9 +105,9 @@ attributes:
require.NoError(t, err)
require.Equal(t, gpuQuantity(1), p.Units)
require.Equal(t, 2, len(p.Attributes))
require.Equal(t, "vendor/nvidia/model/a100/40Gi", p.Attributes[0].Key)
require.Equal(t, "vendor/nvidia/model/a100/ram/40Gi", p.Attributes[0].Key)
require.Equal(t, "true", p.Attributes[0].Value)
require.Equal(t, "vendor/nvidia/model/a100/80Gi", p.Attributes[1].Key)
require.Equal(t, "vendor/nvidia/model/a100/ram/80Gi", p.Attributes[1].Key)
require.Equal(t, "true", p.Attributes[1].Value)
}

Expand All @@ -129,7 +129,7 @@ attributes:
require.Equal(t, 2, len(p.Attributes))
require.Equal(t, "vendor/nvidia/model/a100", p.Attributes[0].Key)
require.Equal(t, "true", p.Attributes[0].Value)
require.Equal(t, "vendor/nvidia/model/a100/80Gi", p.Attributes[1].Key)
require.Equal(t, "vendor/nvidia/model/a100/ram/80Gi", p.Attributes[1].Key)
require.Equal(t, "true", p.Attributes[1].Value)
}

Expand Down

0 comments on commit 6ad32ce

Please sign in to comment.