New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace uri-js
with fast-uri
#2415
base: master
Are you sure you want to change the base?
Conversation
Less dependencies. Better performance. This is the way! |
I would be very happy if there were an initial review or at least a comment from the AJV team. |
how progress of this? |
how progress of this? |
No feedback from maintainers, can't move forward :( |
I see that there is still a version of this library released recently, |
Yes, other pull requests are getting merged and I believe this one is just ignored. Some feedback - any feedback - from the maintainers would be appreciated |
Hi all, I will try and get some guidance from @epoberezkin on this one. Sorry I missed your activity here. |
Haha, merge and release a version as soon as possible 😁 |
Ready |
What issue does this pull request resolve?
This PR fixes issues #2350 and #2343. It removes the (deep) dependency on
punycode
, a deprecated module.What changes did you make?
I replaced the default uriResolver to fast-uri instead of uri-js.
Is there anything that requires more attention while reviewing?
This PR supersedes #2377.
It is also worth considering using the web API
URL
which is defined in URL Living Standard instead ofURI
which is defined in RFC 3986 and is less prevalent and can resolve the issue raised by @jasoniangreen in the above linked PR:We can use the native
URL
API as it is supported with node 10+ and all major browsers and it has 97.68% caniuse score whileURI
is not standardized afaict.Thanks!
TODO: