Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 204 as a successful query, and exclude 204 body from error types #66

Merged
merged 1 commit into from Mar 26, 2024
Merged

Support 204 as a successful query, and exclude 204 body from error types #66

merged 1 commit into from Mar 26, 2024

Conversation

smaspe
Copy link
Contributor

@smaspe smaspe commented Mar 13, 2024

204 body would typically be empty, but should still be excluded from _OpErrorType

@ajaishankar
Copy link
Owner

Thanks @smaspe!

@ajaishankar ajaishankar merged commit 5405963 into ajaishankar:main Mar 26, 2024
@smaspe smaspe deleted the patch-1 branch March 26, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaishankar ajaishankar ajaishankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaspe @ajaishankar