Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite in typescript and shared / distributed locking #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

simllll
Copy link

@simllll simllll commented Apr 22, 2021

Hi @aishek , thanks for your awesome work, this Pr is not intended for merging as it contains several changes which are not relevant, but it cointains two things that might be of interest for you:
1.) it is a rewrite in typescript
2.) it changes the rate liminting approach to the one of https://github.com/nfriedly/express-slow-down and also allows to plug in the same stores that express-slow-down and express-rate-limit have already, this furthermore allows to use a "reids" or "memcached" store instead of the memory one, which allows to share locks between different processes/instances.

Feel free to cherry pick commits from my fork and bring them back in to the main library :-)!

npm: https://www.npmjs.com/package/@hokify/axios-rate-limit
source. https://github.com/hokify/axios-rate-limit

Thanks again

@aishek
Copy link
Owner

aishek commented Apr 28, 2021

Oh, thank you very much! I need some time to review the changes

@buenofs
Copy link

buenofs commented Sep 28, 2022

Oh, thank you very much! I need some time to review the changes

Where you able to review the changes @aishek ? I'm currently using this fork to work with Redis but tbh if it were merged to the main project would make it much easier to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants