Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include argument name for ArgumentExceptions in NmeaLineParser #153

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Include argument name for ArgumentExceptions in NmeaLineParser #153

wants to merge 4 commits into from

Conversation

fredeil
Copy link

@fredeil fredeil commented Apr 7, 2022

Add parameter to argument exceptions

Closes #152

@idg10
Copy link
Contributor

idg10 commented Apr 14, 2022

Sorry - I got COVID so I've been behind on this.

It looks like the tests are failing. Did you run the tests locally?

@fredeil
Copy link
Author

fredeil commented Apr 19, 2022

Hi again,
There are some specs that are failing. I'm not sure what to make out if these error messages to be honest
image

@fredeil
Copy link
Author

fredeil commented Apr 19, 2022

I guess I have to add the (Parameter 'line') to those sentences

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@fredeil
Copy link
Author

fredeil commented Apr 20, 2022

Fixed the tests and signed CLA @idg10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NmeaLineParser should include argument name in ArgumentException
3 participants
@fredeil @idg10 @CLAassistant