Improve, simplify shell script #2592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix unbound shell variable warning from 'set -u' about GITHUB_SHA being unbound. Seen when running build locally.
- Remove obsolete SVN support
- This section had a bug in it anyway -- $REVISION could never be
empty since it starts out with REVISION="_r$(...)" - it would always
start with '_r' regardless of what the subshell echoed, so yeah,
never empty.
- svn.aircrack-ng.org's DNS record is also no longer up
- Fix various quoting issues reported by shellcheck.
- Avoid pedantic variable checking by just using defaults
(${VAR:-'default value'})
- Change else-if chain to 'case'
|
Oh, and if you prefer I fix the SVN support rather than remove it, I can do that too. |
Tusenka
approved these changes
Dec 31, 2023
|
|
||
| if [ x$DIR = "x" ] | ||
| then |
|
|
||
| VERSION=$(cat ${DIR}/AC_VERSION 2>/dev/null) | ||
| VERSION=$(cat "$DIR/AC_VERSION" 2>/dev/null) |
There was a problem hiding this comment.
I removed it because, despite what shellcheck may tell you, the {} is not necessary, it's just extra characters in the line.
I have a hypothesis that whoever wrote this originally thought that ${VAR} was the same thing as "$VAR" for the purposes of quoting. It's an easy mistake to make.
There was a problem hiding this comment.
| echo $REVISION | ||
| fi | ||
| case $CMD in | ||
| 'scm') |
Tusenka
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set -uaboutGITHUB_SHAbeing unbound. Seen when running build locally.$REVISIONcould never be empty since it starts out withREVISION="_r$(...)"- it would always start with_rregardless of what the subshell echoed, so yeah, never empty.svn.aircrack-ng.org's DNS record is also no longer up${VAR:-'default value'})case