build: add option to disable bsd library inclusion #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be needed to disable bsd inclusion and fallback to the compat functions even if bsd headers are detected. This is the case when multiple library are cross-compiled and someone wants to explicitly compile aircrack-ng without linking to bsd library. With the current implementation, if a bsd header is detected, the bsd library is always linked even if unwanted. Add option to configure this with the combo --with-libbsd=yes|no|auto with auto set by default. Also add an extra featurw with introducing the possibility of requiring the bsd library and fail the configure phase. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Musl or recent glibc added support for these additional string function, strlcat and strlcpy hence the compat function are not needed and the builtin version can be used instead. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be needed to disable bsd inclusion and fallback to the compat functions even if bsd headers are detected.
This is the case when multiple library are cross-compiled and someone wants to explicitly compile aircrack-ng without linking to bsd library.
With the current implementation, if a bsd header is detected, the bsd library is always linked even if unwanted. Add option to configure this with the combo --with-libbsd=yes|no|auto with auto set by default.
Also add an extra featurw with introducing the possibility of requiring the bsd library and fail the configure phase.