Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airodump-ng: Sort by uptime #2168

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elig0n
Copy link
Contributor

@elig0n elig0n commented Jul 27, 2020

No description provided.

@gemesa
Copy link
Contributor

gemesa commented Feb 22, 2023

Can you update this according to the current implementation?

@elig0n
Copy link
Contributor Author

elig0n commented May 13, 2023

Can you update this according to the current implementation?

@gemesa I don't see any conflicts against the master branch. Can you be more specific ?

@elig0n
Copy link
Contributor Author

elig0n commented Sep 8, 2023

@gemesa ?

@gemesa
Copy link
Contributor

gemesa commented Sep 8, 2023

Yes, so now with your change the code would look like this:

				case SORT_BY_UPTIME:
					snprintf(lopt.message,
							 sizeof(lopt.message),
							 "][ sorting by uptime");
					break;
				default:
					break;
			}
			ALLEGE(pthread_mutex_lock(&(lopt.mx_sort)) == 0);
			dump_sort();
			ALLEGE(pthread_mutex_unlock(&(lopt.mx_sort)) == 0);
		}

				default:
					break;
			}
			ALLEGE(pthread_mutex_lock(&(lopt.mx_sort)) == 0);
			dump_sort();
			ALLEGE(pthread_mutex_unlock(&(lopt.mx_sort)) == 0);
		}

I think this is a copy paste error. To fix it remove the unnecessary changes:

			default:
					break;
			}
			ALLEGE(pthread_mutex_lock(&(lopt.mx_sort)) == 0);
			dump_sort();
			ALLEGE(pthread_mutex_unlock(&(lopt.mx_sort)) == 0);
		}

and keep this:

			case SORT_BY_UPTIME:
					snprintf(lopt.message,
							 sizeof(lopt.message),
							 "][ sorting by uptime");
					break;

@gemesa
Copy link
Contributor

gemesa commented Sep 8, 2023

The other changes LGTM. Can you post some test measurements so @Mister-X- will see your feature is working? Something like this: #2457 (comment)

removed unnecessary paste duplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants