Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print a helpful breadcrumb when we print the chooser #1962

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChrisLundquist
Copy link
Contributor

@ChrisLundquist ChrisLundquist commented Sep 22, 2018

This makes it easier for users to take the fast path / single pass

# When I don't know what networks there are in a pcap
$ ./src/aircrack-ng /srv/wifi/home-01.pcapdump
# ...
Index number of target network ? 675
Use ./src/aircrack-ng -b F8:1D:0F:01:88:08 to load this target faster
Opening /srv/wifi/home-01.pcapdump
Read 11246612 packets.

1 potential targets

essid: "<redacted>" bssid: "F8:1D:0F:01:88:08"
Please specify a dictionary (option -w).

# When I know the target
 $ ./src/aircrack-ng  /srv/wifi/home-01.pcapdump -b F8:1D:0F:01:88:08
Opening /srv/wifi/home-01.pcapdump
Read 11246612 packets.

1 potential targets

essid: "<redacted>" bssid: "F8:1D:0F:01:88:08"
Please specify a dictionary (option -w).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 38.597% when pulling c5ad41b on ChrisLundquist:clundquist/forward-breadcrumbs into 93c7468 on aircrack-ng:master.

@aircrack-ng
Copy link
Owner

The tip should only be displayed if it takes more than a few seconds to parse the capture file(s). Something like 2-3 seconds.

Please add a newline before Opening /srv/wifi/home-01.pcapdump.

What is the purpose of displaying the essid and bssid again after selecting the network as well as the amount of potential target (which seems incorrect in the first output considering there are at least 675 networks)?

@ChrisLundquist
Copy link
Contributor Author

ChrisLundquist commented Sep 23, 2018

What is the purpose of displaying the essid and bssid again after selecting the network

Feedback for the user in case they misread the number, or so they could -e or -b .

amount of potential target (which seems incorrect in the first output considering there are at least 675 networks)?

We don't have to print that, but it is the number of networks that matched BSSID or ESSID (for multi target support)

@aircrack-ng
Copy link
Owner

Let's remove the ESSID/BSSID printout.

For potential target, just add a warning if there is more than 1 BSSID that match the ESSID provided (it's up to you if you want to provide the list of BSSID)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants