Make NGNIX unprivileged docker images as default #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your branch is not currently up-to-date with |
|
Kudos, SonarCloud Quality Gate passed!
|
nexcalmart
force-pushed
the
nexcalmart/nginx-unprivileged
branch
from
59db2bb
to
d175db6
Compare
|
Your branch is not currently up-to-date with |
|
@perangel This PR should be closed out by your work. |
|
Your branch is not currently up-to-date with |
nexcalmart
force-pushed
the
nexcalmart/nginx-unprivileged
branch
from
d175db6
to
6446c83
Compare
|
|
Your branch is not currently up-to-date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To support non-root deployments on k8s NGINX has to be configured to work without root privileges.
There is already an official docker image of NGINX in an unprivileged mode.
Since the webapp doesn't need privileged access rights this has to be taken as the default docker image for the webapp.
How
Change the build configuration to switch to the non-privileged docker image if not explicitly overwritten by the env variable.
Recommended reading order
1-
Can this PR be safely reverted / rolled back?
🚨 User Impact 🚨
No