Make container ports configurable to support unprivileged ports #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drtikso
approved these changes
Nov 21, 2023
nexcalmart
force-pushed
the
nexcalmart/helm-config-port
branch
from
32c80af
to
e620fff
Compare
|
Hi, |
|
Your branch is not currently up-to-date with |
|
|
|
Your branch is not currently up-to-date with |
|
|
Your branch is not currently up-to-date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This change enables flexibility to container ports in the deployment resource for the webapp and the connector-builder-server. This is one step further to support non-priviledged deployment.
How
Recommended reading order
Can this PR be safely reverted / rolled back?
🚨 User Impact 🚨
No user impact.