Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for private image registry #284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cnogradi
Copy link

Add a chance for user to specify an additional private image registry without change seed_sources/seed_destinations

What

* Add an additional options to specify private image registry beside of `imagePullSecrets`

How

Add registry prefix in ProcessFactory on create new container if the environment JOB_KUBE_MAIN_CONTAINER_IMAGE_REGISTRY has been assigned a valid registry string.
This change was inspired and adapted from airbytehq/airbyte#16969

Recommended reading order

1. `airbyte\airbyte-workers\src\main\java\io\airbyte\workers\WorkerConfigs.java`

2. `airbyte\airbyte-workers\src\main\java\io\airbyte\workers\process\DockerProcessFactory.java`

3. `airbyte\airbyte-workers\src\main\java\io\airbyte\workers\process\KubeProcessFactory.java`

4. `airbyte\airbyte-workers\src\main\java\io\airbyte\workers\config\WorkerConfigurationBeanFactory.java`

User Impact

This option is transparent and optional for airbyte users.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CLAassistant
Copy link

CLAassistant commented May 7, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants