Fix transform matrix precalculation when adding effects #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset the precalculated matrix and appliedTransformations in precalculateMatrix(). Check for the existence of an effect on the anchor point property instead of checking if it's keyframed. -- The transform matrix might be precalculated again when effects are added to various properties of the transform. However, the matrix was not being reset to identity, and the appliedTransformations member was not being reset to 0, which caused components of the transform to be applied multiple times. (To reproduce: create an animation, and at a later time, apply an effect to the rotation using transform.r.addEffect(). Observe how the object gets a rotation that is the sum of the initial value and the one returned from the effect, when it should just be the value returned to the effect.) Additionally, for the anchor point property, its eligibility for precalculation was checked only by considering whether it's keyframed, when it also could have had an effects sequence added. (To reproduce: create an animation, and at a later time, apply an effect to the anchor point via transform.a.addEffect(). Observe how the effect does nothing, as the anchor point would still end up precalculated.)
geomaster
changed the title
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transform matrix might be precalculated again when effects are added to various properties of the transform. However, the matrix was not being reset to identity, and the appliedTransformations member was not being reset to 0, which caused components of the transform to be applied multiple times.
(To reproduce: create an animation, and at a later time, apply an effect to the rotation using transform.r.addEffect(). Observe how the object gets a rotation that is the sum of the initial value and the one returned from the effect, when it should just be the value returned to the effect.)
Additionally, for the anchor point property, its eligibility for precalculation was checked only by considering whether it's keyframed, when it also could have had an effects sequence added.
(To reproduce: create an animation, and at a later time, apply an effect to the anchor point via transform.a.addEffect(). Observe how the effect does nothing, as the anchor point would still end up precalculated.)