Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where large GradientFill / GradientStroke would be cut off #1721

Merged
merged 6 commits into from
Aug 16, 2022

Conversation

calda
Copy link
Member

@calda calda commented Aug 16, 2022

This PR fixes an issue I noticed in #1717 where the large GradientStroke was being cut off, because it was larger than the hardcoded GradientRenderLayer.gradientPadding.

Before After
Simulator Screen Shot - iPhone 12 Pro Max - 2022-08-16 at 10 16 49 Simulator Screen Shot - iPhone 12 Pro Max - 2022-08-16 at 10 16 28

Copy link
Collaborator

@erichoracek erichoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calda calda enabled auto-merge (squash) August 16, 2022 18:21
@calda calda merged commit 4ca8023 into master Aug 16, 2022
@calda calda deleted the cal--1717 branch August 16, 2022 18:44
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants