Add hasOwn to section 3.7
#2610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 18, 2022
There was a problem hiding this comment.
We should wait to land this until airbnb-js-shims is using https://npmjs.com/object.hasown or similar
|
@maurer2 since you deleted the fork, this sadly can never be merged. |
|
Hello, totally forgot to close this before deleting the repo when doing some cleanup work. Sorry. |
|
Closing it first wouldn't have helped; until a PR is merged (or closed as a wontfix) the fork can't ever be deleted, or the PR is unrecoverable. |
|
Okay, I see. Thanks I can recreate the pr and add it to the issue ticket, if it still makes sense to add this to the style guide. What do you think? Cheers |
|
At this point let's just leave it as is; it's not clear if airbnb-js-shims is maintained or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion related to this pr: #2606