Create CHIP-8.md #736
Open
Create CHIP-8.md #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andrewlee-stripe <80125871+andrewlee-stripe@users.noreply.github.com>
Signed-off-by: andrewlee-stripe <80125871+andrewlee-stripe@users.noreply.github.com>
| - `Join` jobs produce outputs at the correct cadence | ||
| - `Join` job results are point-in-time correct for a mix of `GroupBy`s with different cadences and accuracies | ||
|
|
||
| ### Changes to Fetcher |
There was a problem hiding this comment.
can we also sketch out what the changes to the GBU data layout will look like? In terms of what time range will be covered in the tailHops and collapsedIr say if we have a 4 hour drop cadence?
| As discussed in New or Changed Public Interfaces, the configuration options for hourly features are additive and will not impact existing features. | ||
|
|
||
| In addition to the correctness tests described in each section under Proposed Changes, Stripe will rigorously test this change internally in its QA environment and do a methodical rollout to partner teams’ features before contributing the change to the upstream. | ||
|
|
There was a problem hiding this comment.
Lets also add a milestones / rollout strategy section? Trying to understand roughly what are the tasks involved and how we can ensure we roll these changes out safely in the repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding
CHIP-8 Hourly GroupBy Batch JobsWhy / Goal
Test Plan
Checklist
Reviewers