Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing prints with logs #633

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Replacing prints with logs #633

wants to merge 7 commits into from

Conversation

ezvz
Copy link
Contributor

@ezvz ezvz commented Dec 5, 2023

Summary

Changing all printlns to user a logger.

Why / Goal

Cleaning up.

Test Plan

  • Local build, local run, unit tests

Reviewers

@nikhilsimha

@ezvz ezvz force-pushed the vz--cleanup_logging branch 3 times, most recently from 63ae081 to f06430c Compare December 5, 2023 22:12
@ezvz ezvz changed the title **NOT READY TO MERGE** Replacing prints with logs Replacing prints with logs Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant