Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Set a time limit for circle ci #598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cristianfr
Copy link
Collaborator

@cristianfr cristianfr commented Oct 27, 2023

Summary

Setting a time limit of 40 minutes for circle CI as metadata calls can run into a 4hr+ loop of failure
Example: https://app.circleci.com/pipelines/github/airbnb/chronon/3408/workflows/2fdc3dd8-904b-4d90-b062-d5879f4bd686/jobs/17449

From: https://support.circleci.com/hc/en-us/articles/11775183948827-How-to-run-a-job-in-the-background-on-CircleCI

A job that has background: true set will run while there are other jobs running but once they have finished the background job will also end, it will not run on its own if there are no other jobs.

Pick 40 minutes since both Spark 3.1.1 and 3.2 run in ~10-20minutes.
Spark 2 can run for 40 minutes but rarely will provide more info than the other two together.

Why / Goal

Improve dev experience.

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant