Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bottom inset to offset calculation #126

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Add bottom inset to offset calculation #126

merged 3 commits into from
Mar 22, 2024

Conversation

elfredpagan
Copy link
Contributor

@elfredpagan elfredpagan commented Mar 22, 2024 •
edited by bryankeller

Details

Related Issue

Adds the adjusted bottom inset to the new offset calculation

Motivation and Context

This resolves an issue where things are not correctly pinned during bounds changes.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

brynbodayle
brynbodayle previously approved these changes Mar 22, 2024
View reviewed changes
bryankeller
bryankeller reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@bryankeller bryankeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, thanks!

@elfredpagan @bryankeller
Update MagazineLayout/Public/MagazineLayout.swift
a2fe2a0 
Co-authored-by: Bryan Keller <kellerbryan19@gmail.com>
@elfredpagan @bryankeller
Update MagazineLayout/Public/MagazineLayout.swift
386b7e5 
Co-authored-by: Bryan Keller <kellerbryan19@gmail.com>
@elfredpagan
Copy link
Contributor Author

Accepted changes

@bryankeller bryankeller merged commit b838d83 into airbnb:master Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryankeller bryankeller bryankeller approved these changes

@brynbodayle brynbodayle brynbodayle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elfredpagan @bryankeller @brynbodayle