Use set_source_pkgconfig instead of set_source #991
Conversation
|
Hi @Sean-Der thanks for the PR! Let's let CI run to see how it turns out. I'm a little doubtful this will work on Windows? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 5816 5839 +23
=========================================
+ Hits 5816 5839 +23 ☔ View full report in Codecov by Sentry. |
|
@jlaine thanks! Should I put this behind a platform check? I don’t understand how it works today on Mac/Linux. If those headers aren’t in /usr/include how does it find it? I needed this change to build on NixOS and my Mac. |
jlaine
force-pushed
the
use-pkg-config
branch
from
8d11321
to
b9da858
Compare
If pkg-config fails (e.g. on Windows), fallback to trying to use standard include and library paths. Co-authored-by: Jeremy Lainé <jeremy.laine@m4x.org>
jlaine
force-pushed
the
use-pkg-config
branch
from
b9da858
to
936bd67
Compare
|
@Sean-Der I've taken a slightly different approach of trying |
I don't fully understanding how Python does FFI, but I don't understand how it would work before.
Now it uses pkg-config and will pull the header locations properly.