Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an interface for all signaling implementations #757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mglettig
Copy link

This will make it easier to inject a custom signalling class.

… it easier to inject a custom signaling class.
@mglettig mglettig changed the title Create an interface for all signaling implementations. Create an interface for all signaling implementations Aug 15, 2022
@rprata
Copy link
Contributor

rprata commented Aug 29, 2022

Could you create a example with this feature?

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #757 (7897501) into main (d7fe37f) will decrease coverage by 0.06%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##              main     #757      +/-   ##
===========================================
- Coverage   100.00%   99.93%   -0.07%     
===========================================
  Files           31       31              
  Lines         5862     5876      +14     
===========================================
+ Hits          5862     5872      +10     
- Misses           0        4       +4     
Impacted Files Coverage Δ
src/aiortc/contrib/signaling.py 97.50% <77.77%> (-2.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants