Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can filter out ipv6 addresses #732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zhuker
Copy link

@zhuker zhuker commented Jun 7, 2022

If you construct peer connection like below, ipv6 addresses will not be gathered

pc = RTCPeerConnection(use_ipv6=False)

@jlaine
Copy link
Collaborator

jlaine commented Jun 16, 2022

This is not part of the standard WebRTC API so I'm not keen to introduce any more API surface. Why don't you filter out the IPv6 candidates before calling setLocalDescription?

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #732 (bd5791b) into main (25de502) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##              main     #732      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files           31       31              
  Lines         5860     5864       +4     
===========================================
+ Hits          5860     5863       +3     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/aiortc/rtcicetransport.py 99.45% <80.00%> (-0.55%) ⬇️
src/aiortc/rtcpeerconnection.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25de502...bd5791b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants