New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playout delay support #668
base: main
Are you sure you want to change the base?
Conversation
This PR has no unit test? |
True, I haven't added any, I will add some tests. |
Ok so I added a test for the playout delay and adapted the ones for header extensions. Also I was wondering: regarding |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 31 +1
Lines 5816 5801 -15
=========================================
- Hits 5816 5801 -15
☔ View full report in Codecov by Sentry. |
Is there a problem with the runners? Seems like the test never started:
|
@jlaine Is there a chance for this PR to progress some time soon? |
Hi,
First, thanks for the awesome library :)
I needed playout delay header extension support for a low latency streaming application (https://webrtc.googlesource.com/src/+/refs/heads/main/docs/native-code/rtp-hdrext/playout-delay/README.md), so I thought I could share it.