Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: code consistency and bot instance creation #1482

Open
wants to merge 4 commits into
base: dev-3.x
Choose a base branch
from

Conversation

sdmway
Copy link
Contributor

@sdmway sdmway commented May 8, 2024

Description

Enhanced the consistency of the codebase by updating the instantiation of the bot instance.

Fixes # (issue)

None

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)

How Has This Been Tested?

Followed steps on: https://docs.aiogram.dev/en/dev-3.x/contributing.html

Test Configuration:

  • Operating System: MacOS Sonoma 14.4.1
  • Python version: 3.11.7

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

✔️ Changelog found.

Thank you for adding a description of the changes

Comment on lines 52 to 54
dp = Dispatcher()

dp.include_router(echo_router)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need routers in this example, this example should still simple

@sdmway
Copy link
Contributor Author

sdmway commented May 11, 2024

@Olegt0rr @JrooTJunior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants