Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answer for exercise 1.1 #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickpellant
Copy link

Hi there. 馃憢 As there are no contribution instructions other than to open a pull request, I thought I'd whip this up and see if it's in an acceptable answer structure.

On that note: it'd be great to see some contribution guidelines added to the README.md. I won't open any more PRs until I know the protocol, and I imagine some contributors won't open a PR at all without one.

@Nalinc
Copy link
Collaborator

Nalinc commented Jul 4, 2019

Hi @nickpellant

Thanks for your pull-request. AIMA Exercises is a GSoC project this summer and the "answer-submission pipeline" is still under development by a student intern. Concrete instructions for contributing will be available after the summer. I will review your submission in nickpellant.md. However, the content from communityanswer.md file is not supposed to be changed. Can you please revert your changes in communityanswer.md?

@sachin10101998
Copy link
Contributor

Hey @nickpellant, thanks for your inputs. A contribution guideline file would be really helpful but the answer submission feature isn't developed completely yet and work is going on over it. As soon as the feature is merged , I'll write a doc so that everyone can browse through the site with ease and understand the differences between various parts. For example, community answer files are being added from this year only and students are not required to send their answers with such a name. The new implementation however is going to provide you with a form to fill your details and answers and you wouldn't have to send a PR in order to it. I'll try to get that part merged by the end of this month. Till then, if you want to send in an answer, I'd request you to make a new file under the markdown/chapter name/ exercises / exercises number/ answers/ directoryand name it anything other than communityanswer.md

@nickpellant
Copy link
Author

Hi @Nalinc! That makes total sense; I stumbled across this repo while working my way through the AIMA hardcopy in my free time, and clearly have arrived a little too soon. 馃槄

I've removed the communityanswer.md commit and just left my submission. @sachin10101998, thank you for your explanation around contributing, makes sense to me. I'll keep my submission named as nickpellant.md for now if that works for you until a naming convention is formalised.

@Mandroide
Copy link

Almost two years passed and nobody else has given an answer to this PR. u.u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants