Use uv to install dependencies in CI #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 60.09% 60.12% +0.02%
==========================================
Files 23 23
Lines 1466 1467 +1
==========================================
+ Hits 881 882 +1
Misses 585 585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielhollas
commented
Mar 13, 2024
danielhollas
commented
Mar 13, 2024
| @@ -1,7 +1,7 @@ | |||
| from pathlib import Path | |||
|
|
|||
| import pytest | |||
| import yaml | |||
| from ruamel.yaml import YAML | |||
There was a problem hiding this comment.
We've been depending on pyyaml for tests by accident, and did not notice since it got installed together with pre-commit. Let's use ruamel since that's what is used in the aiidalab package.
danielhollas
changed the title
danielhollas
commented
Apr 10, 2024
There was a problem hiding this comment.
@superstar54 could you take a look? This might be beneficial for QeApp as well.
This reverts commit 4cd0c59.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uv is the new cool kid in the town of Python packaging, from the creators of ruff. It currently serves as a much faster drop-in replacement for pip.
For the
aiidalabpackage, this drops installation time from ~15s to ~2s, which nearly halves the workflow time since the tests we have here are pretty quick.Couple other small changes (feel free to push back)
remove bumpver and pre-commit from direct dev dependencies, as proposed on Discourse