Update to Python-3.10 image #337
Conversation
danielhollas
force-pushed
the
python3.10
branch
2 times, most recently
from
91c073f
to
43a219f
Compare
danielhollas
force-pushed
the
python3.10
branch
from
43a219f
to
34d7e19
Compare
|
@danielhollas, I am redirected from the "bump watchdog" issue. I wonder if we target directly to python 3.11? |
|
I would love to switch to 3.11, but I haven't found the jupyter base image with 3.11, so I think we need to wait. I did some basic testing with the 3.10 image and it seems to work so I would go for it. |
Okay, that makes sense. Just pin me to review when this is ready. |
|
Both AWB and QeApp test suites passed. 🎉 aiidalab/aiidalab-widgets-base#404 This is still blocked on the watchdog bump PR, but once that is merged this could be merged as well. |
Not sure why the build started failing now.
|
For some reason, the Python 3.10.8 started failing when installing aiida-core via mamba, complaining about the In any case, using the 3.10.6 seems to fix this. |
|
If the tests all pass, it is fine for me to merge this. Let me know if you think this is ready. |
unkcpz
force-pushed
the
main
branch
4 times, most recently
from
486feb1
to
0897d53
Compare
|
Seems the problem with the python version from CI for pyYAML, I'd rather pin the python of CI to |
|
@unkcpz it would be great if you could (in a separate PR) pin all the build dependencies in |
|
Looks like the particular issue is caused by a new release of Cython which breaks PyYAML builds. |
| # - name: Run tests ✅ | ||
| #run: VERSION=newly-build pytest -s tests/test-common.py tests/test-${{ inputs.image }}.py --variant ${{ inputs.image }} | ||
| #shell: bash |
There was a problem hiding this comment.
Why did you comment this out? The time bottleneck was during the upload the images as artifacts, it is an issue from GitHub side.
| @@ -22,7 +22,7 @@ RUN if [ "$TARGETARCH" = "arm64" ]; then \ | |||
| fi | |||
|
|
|||
| RUN fix-permissions "${CONDA_DIR}" | |||
| RUN fix-permissions "/home/${NB_USER}/.aiida" | |||
| RUN fix-permissions "/home/${NB_USER}" | |||
Well, not fine. :-D The tests are failing when trying to install |
Yes, I just encounter it while testing aiidalab/aiidalab-widgets-base#496, and sorry for the delay of that. |
Just a note, the change here is not only updating Python to 3.10, the whole Jupyter stack as well so we really need to test very carefully. For example, I just noticed some strange behaviour in StructureViewer, although I need to still confirm where it is coming from. But there is for example this open issue on @unkcpz If you want to help move this along, it would be great if you could carefully test the QeApp on this image. Among others, please test the Optimade widget and than merge this PR. |
|
@danielhollas thanks! I agree a careful test is needed. I realize the new Python version actually brings a new list of dependencies if I run such as
I fix the build problem of pymatgen, which seems from CPython as well. Can you bring the test back to see if it works fine? |
This reverts commit 33946f6.
Tests are now passing, thanks! 🎉 |
|
Just a note that a bunch of notebook AWB tests are failing for the latest image from this PR, see aiidalab/aiidalab-widgets-base#404 , so there's definitely something fishy going on. If it turns out to be too difficult to fix, we can try to downgrade the image to earlier version of Python in the 3.10.x series, which have older Jupyter dependencies. |
|
Hi @danielhollas, is there anything can be proceeded or need to investigate on this PR or aiidalab/aiidalab-widgets-base#404? |
|
Superseded by #455 |
Testing if we can upgrade to Python 3.10 Jupyter image.