Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New build scripts for linux #509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raffaem
Copy link
Contributor

@raffaem raffaem commented Dec 1, 2022

Allow either portable build or local build, and clearly document the two.

@ahrm
Copy link
Owner

ahrm commented Dec 1, 2022

I think this breaks our github actions build scripts. Also instead of having to separate scripts, there should be a single script that takes an argument whether we want to be portable or not (like build_and_release.sh).

@raffaem raffaem force-pushed the linux_build_scripts branch 2 times, most recently from d9910bb to 38fc19b Compare December 1, 2022 13:11
@raffaem
Copy link
Contributor Author

raffaem commented Dec 1, 2022

We can default to portable to preserve current workflows

@raffaem raffaem closed this Dec 1, 2022
@raffaem raffaem reopened this Dec 1, 2022
@raffaem raffaem force-pushed the linux_build_scripts branch 2 times, most recently from c7f9dd0 to 9aca952 Compare December 2, 2022 19:42
@raffaem
Copy link
Contributor Author

raffaem commented Dec 4, 2022

Does this works?

@ahrm
Copy link
Owner

ahrm commented Dec 4, 2022

I would have to test in on multiple platforms. Currently I am preparing to release a new version, so I don't want to mess with the build system, I will probably merge this after releasing the new version.

@raffaem
Copy link
Contributor Author

raffaem commented Dec 4, 2022

I would have to test in on multiple platforms.

Yes that sounds good 🙂

@raffaem raffaem force-pushed the linux_build_scripts branch 2 times, most recently from 928f07e to 2c56699 Compare December 16, 2022 19:15
@raffaem raffaem force-pushed the linux_build_scripts branch 2 times, most recently from 1b704c3 to 10512e4 Compare December 24, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants