Improve Ace.js Dart interop with a custom facade #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porting code from ace.dart to a plain old interop
Almost got the marker at cursor stuff to work, just needs a little more tweaking
Rename Range to AceRange to prevent conflicts with the browser's builtin Range class. Rename AceActionRegion to AceActionBundle so that the names don't appear redundant. Fix AceRange.fromPoints() static method to actually work!
ahirschberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for merge yet, still needs improvements on lesson_serializer.dart and scheme for loading lesson files into /edit/ for editing.
Removes ace.dart dependency, adds ace.js dart facade generated from the typescript definitions.
Will close #27