Bug #915629: Allow --ignore-branch for 'gbp pq' #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agx
reviewed
Dec 12, 2018
agx
reviewed
Dec 12, 2018
| @@ -487,7 +487,8 @@ def main(argv): | |||
| except GitRepositoryError: | |||
| # Not being on any branch is OK with --ignore-branch | |||
| if options.ignore_branch: | |||
| current = repo.get_commits(num=1, | |||
| current = repo.get_commits( | |||
| num=1, | |||
There was a problem hiding this comment.
The "branch name" is o.k. but did you verify e.g. "gbp switch" works with this? It would be good to have a test in tests/component/deb/test_pq.py that makes sure we don't break this behavior. Most of the functions called assume it's a branch we're working on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4c0f956 adds support for the
importcommand. Is this a good way to do it?22fe91b is a cosmetic change just to generate shorter
patch-queue/branch names. With this, patch queue branches will be named such aspatch-queue/03e0b41. Without this, pq branches would be named likepatch-queue/03e0b4134690062fb7a358592f85df8c7ff31bbd. This is just a cosmetic commit, not very important given that patch-queue branches tend to be short lived. But it's added here just in case it's seen as a good idea.