Enabled SSL in vault #444
Enabled SSL in vault #444
Conversation
|
@ashu3103 The bug fix should be a separate pull request |
Done! |
|
Kindly first merge the bug-fix commit then I'll rebase this. |
|
@jesperpedersen PTAL |
| @@ -489,6 +489,7 @@ pgagroal_management_get_password(SSL* ssl, int fd, char* username, char* pass) | |||
| char buf[4]; | |||
| int* password_length = NULL; | |||
| char password[MAX_PASSWORD_LENGTH]; | |||
| char buffer[strlen(username) + 4]; | |||
There was a problem hiding this comment.
I am sending strlen(username) + username to the remote in the same stream so first 4 bytes are for the length of username string and the last strlen(username) bytes for the username data that's why I have allocated strlen(username)+4 memory.
|
Aren't you missing the TLS properties in pgagroal-vault.conf for the |
While going through the code of |
|
Ok, but at least we need documentation for that - so See |
I have added the requirements on how to enable SSL in
I really can't find on how to handle manuals in |
Can you brief what is the difference between both the files like why are we maintaining both if the content is almost similar as both of these are talking about configurations of |
|
Yes, currently the content will be the same - or almost - See https://github.com/agroal/pgagroal/blob/master/doc/DEVELOPERS.md#generate-user-and-developer-guide to make sure that the manuals are being generated during your build |
|
Think of |
Thanks :) |
|
Merged. Thanks for your contribution ! |
WORK IN PROGRESS
Main Feature
@jesperpedersen PTAL.
The main objective of this commit is to enable SSL feature for the vault i.e. establishing secure SSL connections between the
vault HTTP serverand the management port ofpgagroal.