Show hostname when inside containers too #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`distrobox` (and other toolbox-like containers) set a hostname, and it is useful to be able to distinguish whether you are inside the container or outside. When /run/.containerenv is present then show the hostname, just as if it was an SSH-ed remote host. Signed-off-by: Edwin Török <edwin@etorok.net>
|
It looks as if Perhaps you could confirm that that is the case? I don't use Your idea looks very clever to me. Give me a while to think if there are any downsides to using it, OK? Thanks so much. |
|
I just opened an issue before checking this pull request, but I think it contemplates this subject. Please, check, if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distrobox(and other toolbox-like containers) set a hostname, and it is useful to be able to distinguish whether you are inside the container or outside.When /run/.containerenv is present then show the hostname, just as if it was an SSH-ed remote host.