Perform speech recognition if dst_language is not denied. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if anyone use `generate_subtitles` function, they don't have to pass dst_language as a required parameter.
agermanidis
force-pushed
the
master
branch
3 times, most recently
from
20e218f
to
477d5a9
Compare
|
If args.dst_language is None, just let args.dst_language = arg.src_language and that would be simpler than setting a is_dst_language_provided variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if user provides
src_languageand don't providedst_languageargument, autosub still performs Speech Recognition, but then return an error (Subtitle translation requires specified Google Translate API key.) and the generated subtitle is not saved. (becausesrc_languageanddst_languageare not the same)In this pull request, if user provides only
src_language, autosub will perform Speech Recognition and saved the subtitle.